Contact-form-main

Community feedback

• 

  Boris•2,850

  @mkborisPosted 4 months ago

  Hi Si1entERA nice work just a few things to look at

  • I’ve noticed that the form isn't submitting even after being filled out, likely due to an issue with the checkbox error not clearing as intended.
  • Also the input fields could use some padding on the left, the contact us text suppose to be a heading element
  • Using semantic elements is great, but for the form itself, a main element around it should be enough, there's no need for a header or footer.
  • figure elements are intended for images and their captions, not for grouping multiple elements. For wrapping a group of elements, a div is more appropriate
  • Media queries, font-size should be defined in rem not px

  Hope this helps

  Marked as helpful

  0

  ---

  

  Si1entERA•450

  @Si1entERAPosted 4 months ago

  Dear @mkboris, Thank you for taking the time to view my code, notify me on my mistakes and provide some helpful advice which I'm currently implementing.

  I was able to fix the checkbox input, which was caused by a mismatch between the name attribute in HTML and the name used in the JavaScript code.

  I also changed all the figure tags to div tags and I'm still in the process of fixing the layout in regard to the header and footer tags.

  'The mistakes of today become the lessons of tomorrow', Thank you again for the advice.

  0

  

  Boris•2,850

  @mkborisPosted 4 months ago

  @Si1entERA no problem, keep going!

  0
• 

  Abubakar Munir•0

  @abubakarmunir712Posted 4 months ago

  Good effort but try to use *{ box-sizing :border-box; } So, the change in border's width does not disturb the rest of the form. Also add some padding in input tags.

  1