Pritesh Dhandhukia• 220
@pritxxh
Posted
The solution includes semantic HTML which is great for accessibility. The layout looks good on various screen sizes due to the responsive design approach. However, there are some areas for improvement:
1. Accessibility could be enhanced by adding proper aria labels, role attributes,
and keyboard navigation support.
2. The code structure could be more modular, with separate files for CSS,
JavaScript, and better organization of components.
3. While the layout matches the design, there could be minor differences in
spacing, font sizes, or colors that could be fine-tuned.
4. The code could be made more reusable by abstracting common functionality
into separate functions or modules.
Overall, it's a solid solution that meets the requirements, but with some tweaks to accessibility, code structure, and attention to detail, it could be even better.
0
@pritxxh Thanks for the unnecessary copy-paste feedback. I suggest you apply this feedback to your own solution before commenting about it, as your own solution doesn't fulfill any of your own nor the challenges criterias.
-
- The form has good accessibility as is. Just adding aria tags to everything doesn't make it better or more accessible.
- A proper form doesn't need to specify roles.
- My form already has native keyboard navigation
-
- Yes, it could but that doesn't automatically mean it's better. Sometimes a quick and dirty script does the job better then a giant "modular" framework/lib/helper could
- My script is already very reusable, extendable and modifiable.
- My project is structured in a way where things don't depend on each other. everything is still functional and fully accessible without the css and/or js part. doesn't need to be "more modular" then that.
-
- It's close enough to not spend any more time on literally shoving around single pixels
-
- You already made that point in p 2. There is nothing in this project that would benefit from more modularity
0
