Congrats! You are the 5000th user to complete the QR code challenge
Design comparison
Solution retrospective
I think working with the design in Figma was the most difficult part. I'm used to approaching web design from a scalable approach, but everything in this design is very set-in-stone and doesn't change regardless of screen size which feels very weird lol. I'm also not too familiar with Figma, and sometimes I'd get dimensions when I clicked on things (eg. the distance between the image and the end of the card), and other times I wouldn't.
Being forced to upload my project publicly also made me super uncomfortable, especially something like this QR code which is super simple, has been done thousands of times by everyone else, and doesn't contribute to the community in any meaningful way.
What specific areas of your project would you like help with?Is there a better way to do the sizing of the elements besides just using px for this, or is that the optimal method for a project like this where we have the exact dimensions and the size of the things on the webpage doesn't change?
Community feedback
- @Alex-Archer-IPosted 5 months ago
Hi!
Well, that's cool that you did it and uploaded here, we both could learn that way - you by receiving tips and me with gathering practice by inspecting someone's code =)
So, here is a couple suggestions, if you don't mind =)
You doesn't need a
role
tag here. At first aria roles have a specific values and there is nocard
role. At second - every semantic tag has it's own role and you should userole
attribute only in rare cases when you can't use semantic tag for some reasons. That doesn't mean that everydiv
should haverole
though, divs often used as mere wrappers and they doesn't really need one.Than, speaking about semantic, every page should contain
main
tag. So you can replacediv
with it.About responsive sizing. For width you can use this trick:
main { max-width: 320px; width: 95%; }
That way your card will keep
320px
width on big screen but be able to shrink on the small ones. You also can omitwidth
at all and it became100%
.As for height I suggest you not to explicit it at all. In most cases (it's always an exceptions of course) it's better when the content defines height of the container. You can omit it and it'll be set to
auto
- default value.I see you use
size
property forp
. Guess you mistyped thefont-size
one =) I really recommend you to get familiar withrem
values and use them for font sizes. That values depends on user's font settings and provide better UE.So. Hope that could helps. Welcome. You did cool. Keep doing =)
And totally don't hesitate to upload you new solutions, ask, comment or stuff =)
Marked as helpful0 - @wiameHaKPosted 5 months ago
It sounds like you've been navigating through some tough challenges with Figma! I think your approach to stick with it despite the unfamiliarity shows determination. It's okay to feel a bit uncomfortable, especially when tools don't behave exactly as expected. Your solution sounds really good and accurate, especially considering you're not too familiar with Figma. I didn't use Figma for the same reason. My solution isn't very accurate ;)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord