Design comparison
Community feedback
- @Saad-HishamPosted over 1 year ago
Hey there!
I just wanted to say that your work is absolutely great✨ You've come up with such a pretty solution. I do have a couple of tips for you that could help make it even better.
Firstly, for improved accessibility, you might want to consider wrapping your div inside the <main> tag instead.
Secondly, the dimensions such as width and height don't seem to match the design. Here are the dimensions you might want to consider for the parent div:
.container { width: 736px; height: 513px; }
I know that you use em and rem instead of pixels you can convert them depending on your solution Overall, I don't really see any issues with your solution, except for the dimension. Keep up the great work✨
Marked as helpful1@Dougl4zPosted over 1 year ago@Saad-Hisham Olá Saad-Hisham!
Muito obrigado pelo feedback, isso importa muito pra mim, já que estou no inicio da jornada. Vou seguir com os desafios com certeza. vlw! : )
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord