@AnnyCaroline
Posted
First, your repository README is very well written!
It's also great to use CSS variables for colors. It helps a lot if you need to implement theme switching or when you need to update a color.
I missed the fonts, thought. You can download it from the link at the style-guide.md and import it at the CSS using @font-family.
Also, the card placement doesn't seem right. I can think of two ways of solving this issue:
- Using
display: flex: define theheightof the body as100vh, and make it a flex container, with bothalign-itemsandjustify-contentascenter. - Using
display: grid: define theheightof the body as100vhand make it a grid container. Then, defineplace-self: center;for your card.
Please, let me know if you need any help fixing the code. My LinkedIn is https://www.linkedin.com/in/anny-chagas/.
@AlfonsoVidrio
Posted
Thank you so much, @AnnyCaroline, for your helpful comments! I'm glad to hear that the README is well-written and that you appreciate the use of CSS variables for colors.
I’ve resolved the centering issue based on your suggestions. I implemented the recommendations regarding display: flex, and the card placement is much better now. 😄
