Design comparison
Community feedback
- @YelemyahMPosted 2 months ago
Hello Coder ! Good Job on completing the challenge !
I have a suggestion for about your code :
-
In your css file, I’ve noticed you’re using
width: 100vw;
andheight: 100vh;
to set the width and height of the body. While this works on many devices, it can cause issues on mobile browsers, where the viewport height can include parts of the UI like the address or navigation bars. This could lead to unwanted scrolling or layout shifts when those bars appear or disappear. -
Consider using
min-height: 100vh;
instead ofheight: 100vh;
to ensure the layout adapts more smoothly across different devices without breaking when these UI elements are present.
I hope you find it useful ! Good Luck and happy coding !
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord