Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

componente card 3 columnas

@Martincillo94

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


¿Que te parece esta solución?

Community feedback

Account Deleted

Hey Martincillo, congratulations on completing the challenge! You did a vary great job 😉

Let me give you some little tips for optimizing your code:

  • in the font-family property don't use cursive because the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... horrible font! I would rather replace it with a font-family:" Big Shoulders Display ", sans-serif
  • you can remove the descriptive text in the alt attribute of the images icons because there are decorative
  • you can remove the margin from cards-container class because with flex they are superfluous
  • use min-height: 100vh instead of height to body
  • add transition on the element with hover effect

Hope this help! Happy coding 😁 by Travolgi

Marked as helpful

0

@Enmanuel-Otero-Montano

Posted

Hola Martincillo94! Felicitaciones por la solución.

Me parece un buen código. Te comento lo que hubiese hecho diferente yo.

  • El div con la clase "cards-container" lo elimino y le pongo esa clase al main
  • Los divs con la clase "card" los cambio por una etiqueta article

Con estos dos cambios tendrías el mismo resultado, pero con menos código y más semántico.

Saludos

Marked as helpful

0

@Martincillo94

Posted

@Enmanuel-Otero-Montano es verdad, no me fije que le puse la clase "cards-container" a un div.. y sobre los divs. tienes razon era mejor usar article :) muchas gracias por el feedback estare trabajando en estos detallitos :)

0

@Enmanuel-Otero-Montano

Posted

@Martincillo94 👍🦾🦾🦾

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord