Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Component create using Flex

@hstachowiak

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@begli-amanov

Posted

Hi @hstachowiak, your solution looks already good and few tweaks we can make to look even better:

  • First of all I would suggest to check the style guide again for property values being same as given in it.
  • There are a lot of divs. You might try to rename one main of them (for example the one on the line 16 and give it a bit more semantic class name, like wrapper or content. I got self kinda same advice on my solution of it. Plus with that, you'll help to make it more accessible.
  • If you'll use a modern css reset, there will be no white border around your entire page. Even though it looks not bad.
  • I would also pay attention on fonts on how and where do you use them.

I hope sincerely that this will help you and motivate to move forward. Please come back to me with any questions. I will be more than happy to assist you.

Cheers Begli

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord