Component create using Flex

Community feedback

• 

  Begli Amanov•80

  @begli-amanovPosted about 2 months ago

  Hi @hstachowiak, your solution looks already good and few tweaks we can make to look even better:

  • First of all I would suggest to check the style guide again for property values being same as given in it.
  • There are a lot of divs. You might try to rename one main of them (for example the one on the line 16 and give it a bit more semantic class name, like wrapper or content. I got self kinda same advice on my solution of it. Plus with that, you'll help to make it more accessible.
  • If you'll use a modern css reset, there will be no white border around your entire page. Even though it looks not bad.
  • I would also pay attention on fonts on how and where do you use them.

  I hope sincerely that this will help you and motivate to move forward. Please come back to me with any questions. I will be more than happy to assist you.

  Cheers Begli

  0
• 

  P

  SidwellCampbell•40

  @SidwellCampbellPosted about 2 months ago

  Awesome attempt!

  0