Completed within 10 minutes using flexbox and grid to align items.
Design comparison
Solution retrospective
Hey so this is my another beginner exercise in front and mentor and I have created a simple card that is a challenge my 5th challenge and I have used flexbox and agreed to align the items vertically and horizontally and it is also optimized for phone and pc as well
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @mudasarmajeed5!
Your solution looks great!
I have a couple of suggestions for improvement:
- First: In order to make your HTML code more semantic, use
<h1>for the main title instead of<h3>. Unlike what most people think, it's not just about the size and weight of the text.
š The
<h1>to<h6>tags are used to define HTML headings.š
<h1>defines the most important heading.š
<h6>defines the least important heading.š Only use one
<h1>per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>, then use<h2>, and so on.- Second: Still about semantic HTML, use
<main>to wrap the main content instead of a<div>.
All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
0 - First: In order to make your HTML code more semantic, use
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord