Submitted almost 5 years ago
Completed Using Atom (HTML, CSS and Bootstrap)
@Vaibhav-chandak
Design comparison
SolutionDesign
Solution retrospective
Is the code good? Tried mobile first approach for the first time. Please leave a feedback.
Community feedback
- @mattstuddertPosted almost 5 years ago
Hey Vaibhav, great work on this challenge. How did you find working mobile-first? Did you like it?
Here are a few pointers after taking a look at your code:
- You're only using
h2
for your headings. I'd recommend using a range of heading levels to create a hierarchy for your content. - Your "Download for..." call-to-actions would be best as anchor tags, as you'd expect them to link to the app stores if this were a fully-functioning website.
- Be sure to add
alt
attributes to yourimg
elements where appropriate. For example, you've left them all empty for the company logos, which makes this content inaccessible to screen reader users. - The
footer
links would work best as anchor tags inside unordered lists, as opposed to paragraphs.
Let me know if you have any questions. Your solution looks great! 🙂
1@Vaibhav-chandakPosted almost 5 years ago@mattstuddert thanks for the feedback. I will take care of these things next time.
0 - You're only using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord