Submitted over 3 years ago
Completed this challenge using very basic css, responsive css
@Nishkarsh01
Design comparison
SolutionDesign
Solution retrospective
Any tips and advice for me would be appreciated.
Community feedback
- @C-likethis123Posted over 3 years ago
In general, I like your code organisation and how clean your code is.
Some things I have noticed:
- On screen sizes below 830px, some of the text tends to overflow out of the container. Instead of setting a fixed height, you could set it to
height: fit-content
. - The size of the statistics in your solution seems to be smaller than the original design
- You have some code that specifies two font weights like this:
font-weight: 400, 700
. I'm not sure whether it works on your side, but in my browser it's flagged as an invalid property value. - The words (particularly the description) in your solution seems to be less spaced out than in the original design. You can add a
line-height: 20px
to increase the spacing between lines.
1@Nishkarsh01Posted over 3 years ago@C-likethis123 Notes have been taken, thanks :)
0 - On screen sizes below 830px, some of the text tends to overflow out of the container. Instead of setting a fixed height, you could set it to
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord