completed single-price-grid-component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace the section tag with the main tag, <h2> with <h1> and <h3> with <h2> to fix the accessibility issues.

  Always begin the heading of the html with <h1> tag, wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  You forgot to give the body a background-color.

  To center .container on the page using flexbox or grid instead of margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  USING FLEXBOX:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  USING GRID:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  There is no need to give .container and .row-1 height values, rather give ."row1-content, .col-1 and .col-2 the same padding values for all the sides, this will prevent the content from overflowing.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Ayush namdev•120

  @ayushprojectsPosted over 1 year ago

  @Hassiai thankyou for your valuable advice.

  0