Design comparison
Solution retrospective
I Used Css-Preprocessor Called Sass! Done It Using Pure Html/CSS(scss). Enjoyed It! Thankyou For The Challenge.
Community feedback
- @Agnik7Posted almost 2 years ago
Hi,
Hope you're doing well.
I went through your solution to this challenge in which you have done a great job. However, I felt there are some things that I learnt while doing these challenges, which might help you as well.
- You are providing a max-width to the
.card
element. I feel that you have already made it responsive, and thus all those media queries are unnecessary. - Try to avoid using
position: absolute
, since it might result in overflow on some screen sizes. You can try using flexbox or grid to achieve the same. To learn different types to center a div, click here. - Replace the
<h5></h5>
tag with the paragraph<p></p>
tag, it will achieve the same result, at the same time, fixing the accessibility issue.
<p>$59.99/year</p>
Hope this comment helps you. If you feel that I have said something incorrect, please do correct me without any hesitation.
Have a nice day!!
Marked as helpful0@vedantlambaPosted almost 2 years ago@Agnik7 Thankyou So Much For Guiding Me, I'll Definitely Re-code All The Things You Said! Once Again ThankYou For Your Valuable Time!
1 - You are providing a max-width to the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord