Design comparison
Solution retrospective
all remarks and suggestion for improvement are surely welcome
Community feedback
- @denieldenPosted over 2 years ago
Hi Ogshabzy, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - to make it look as close to the design as possible add
border-radius: .8rem and overflow: hidden
to.big-pics
class - remove all
margin
from.main
class because with flex they are superfluous - use
justify-content: center
flexbox property to the body to center the card - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁 Hope this help!
Marked as helpful0 - add
- @SamadeenPosted over 2 years ago
Hey Ogundiran!! Cheers 🥂 on completing this challenge.. . Here are my suggestions as regards your accessibilities issues 1.You should use <main class="container"> instead of <div class="container">. 2. Go down orderly when you are using the headings h1 down to h2 down to h3 and so on. 3. Your images can stand alone in a div as a block element no need to include headings to your images
. Regardless you did amazing.. Happy coding!!!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord