Design comparison
Solution retrospective
This project went pretty smoothly. Had a bit of a problem with the responsive part, but the JS was pretty simple.
Is there any way to improve my html, css and JS code?
Community feedback
- @jameslegoff92Posted about 2 years ago
Hi there BlunderBarry,
Good work on this project but there's just a few things I'd like to point out.
-
At smaller screen sizes the image no longer takes up the entire width of the viewport. This can be fixed by adding a width of 100% to your image element.
-
The button on smaller screen sizes should be centered. This can be fixed by getting rid of the 80% width value that's is on your form.
To help you with responsive design I would recommend reading the book "Responsive Web Design" by Ethan Marcotte. Great intro book into responsive web design.
I'd also challenge you to fix the body element on your project. It currently doesn't cover the entire viewport height and it is ruining your background colour. Good luck!
Happy Coding!
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord