Design comparison
SolutionDesign
Solution retrospective
Good morning guys! This is my second project with JS here so every suggestion is appreciated. Happy coding :)
Community feedback
- @Hanka8Posted over 2 years ago
Hi Jimmy, nice job!
My suggestions:
• You can add multiple classes in "element.classList.add()" or "element.classList.remove()", so your JS code will be a little bit shorter;
• when there is no text content in the <button> tag, you should add the "aria-label" to label the element or "aria-labelledby" referencing to some other element with accesible name;
• there are no margins around the content in the design;
Other than that your solution is great, keep up the good work!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord