Coming Soon page using flex-box

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Alberto! 👋

  Regarding the issues that you have:

  • For the Facebook icon, I'm not sure what causes it. Is the circle a part of the icon?
  • The inline script needs to be put after the element is already rendered. Remember, HTML is parsed line by line which means that the script will not know there's an element with an id of mail because it already runs before the form element is found. So, I recommend putting it right before the closing tag of the body. Also, I recommend moving all the JavaScript to an external file. This way, everything will be on its own file.

  Regarding your questions,

  • There's no need to set width and height. I would strongly recommend only setting max-width to prevent the element from becoming too large on widescreen.
  • It's possible to do that, there's an article from CSS Tricks that will show you how to do that. However, I recommend doing the challenge with JavaScript since it is a JavaScript challenge.

  Some recommendations from me.

  • I suggest leaving the alt="" empty for the illustration image. It's a decorative image.
  • The most important content on the page is the logo. Without that information, screen reader users or a search engine would not know what your site/project is called.
  • Those social media icons should be wrapped with anchor tags. They are actually social media links for the company.
  • Changing the html or root font size can cause huge accessibility implications for those of the users with different font size or zoom requirements. Read what an accessibility expert (Grace Snow) has said about it.

  That's it! Hope this helps.

  Marked as helpful

  1