Design comparison
Solution retrospective
I know my JS isn't quite right, obviously because it isn't working and is always showing the error message. But I'm wondering what the proper way would be. Even if my code did work, I believe it would only run once, when I need it to run and check for an invalid pseudoclass every time something new is typed in the box.
I was also wondering if there was any problem with how I relied on built in browser validation rather than using javascript or a library.
Thanks!
Community feedback
- @ericsalviPosted about 2 years ago
Hey @maiaflow,
Great job from a rendered finished product. You have come a long way in the few that you have submitted. This one is very responsive. The only thing I would keep on remembering to do is check out the report that gets generated on your submission. https://www.frontendmentor.io/solutions/coming-soon-page-using-flexbox-and-built-in-validation-OcWjIS-An6/report You have a few accessibility ones that can easily be fixed.
Now one it comes to the JS.... there are many different ways to approach this and it really comes down to what works for you. The way I created mine is what made sense in my head but the way you attacked it is something I would not have thought of.
I did find out about pattern parameters on certain inputs that take Regex so maybe doing your way with patterns might help if you decide to finish this one up.
Check out: https://www.youtube.com/watch?v=g-Y31Iswr2M
Cannot wait to see your next submission.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord