Submitted over 4 years ago
Coming Soon Page: Flexbox, Grids, SCSS and Vanilla Javascript
@wellspr
Design comparison
SolutionDesign
Solution retrospective
Any comments or suggestions will be very appreciated! :)
Community feedback
- @rfilenkoPosted over 4 years ago
Hello, great job, but I see few issues here:
- use semantic html tags, overuse of divs in general;
- there should be only one h1 on a page;
- button should be definately a button, not a div, that really important;
- probably better to load one css file, fewer requests;
Try to work on those😉. Cheers, Roman
0@wellsprPosted over 4 years ago@rfilenko, thank you very much for the suggestions, they are very useful. I changed the button and now it is an input of type submit; also, now I have a single h1. On the other hand, I still haven't change HTML to be more semantic and still have multiple css stylesheets.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord