Coming soon challenge with submit form

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  This looks really sweet, good job!

  Just a few small suggestions :

  • make sure your logo alt text says the name of the site/product (really important)
  • remove the unnecessary empty label Element as assistive tech may still announce its presence
  • remove the section element. That's for sub content not the whole page
  • remove the article element (same reason)

  You could use header (for the logo) and main (for everything else) instead on this, but that would probably break your layout, so I wouldn't change that now

  I hope that makes sense and helps you

  1

  ---

  

  Vjekoslav•485

  @Vj3koPosted almost 4 years ago

  @grace-snow jeah i never know what to use, a div, or a main, or section etc, is there some good article about it? i thought its just personal choosing. Saw a lot of videos people using only divs, and in another only sections etc. that empty label element adds the text below when u enter empty or invalid email. thanks for feedback :D

  0

  

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  @Vjekoni ah I see. That's not what a label element is for really, so I'd swap that for a paragraph. Or... Keep the label but give it an ID and hidden attribute. When invalid message shows

  • add aria-desciribedby error Id to the input
  • remove the hidden attribute from error
  • add aria-live polite to the error

  That will announce the presence of the error for screenreaders ☺

  1