Design comparison
Solution retrospective
This is my solution for the challenge. please give me your review it will help me. check the responsive design et tell me what are the problems.
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @SFN98!
Your project looks great!
I have one suggestion for you to improve it even more:
- Using
margin
is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:
π Apply this to the body (in order to work properly, don't use position or margins):
body { min-height: 100vh; display: flex; /* it works with grid too */ justify-content: center; align-items: center; }
I hope it helps!
Other than that, great job!
Marked as helpful0 - Using
- @Ezekiel225Posted 9 months ago
Hello there π @SFN98.
Good job on completing the challenge !
Your project looks really good!
I have a suggestion about your code that might interest you.
There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.
Consider using External CSS instead of Internal CSS in you future projects.
I hope this suggestion is useful for future projects.
Other than that, great job!
Happy coding.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord