Column Preview, HTML/CSS

Community feedback

• 

  Marie Pascale Brunelle•230

  @mpbrunellePosted over 2 years ago

  Hi kefiiiiR,

  To answer your question about the alignment of the buttons:

  If you add a display: flex on each card, you could then add a flex-grow: 1 on each .card-description element. By default, flex-grow is set to 0, which means that each element never takes more space than the minimum. If you set this property to 1 on .card-description and not on the other elements, .card-description take all the space available and push the other elements to the top and bottom.

  Hope this helps.

  Marked as helpful

  0

  ---

  

  kefiiiiR•70

  @kefiiiiRPosted over 2 years ago

  @mpbrunelle Hi Marie, That is perfect, thank you very much! I just had to add flex-direction: column so it is in correct order. Really appreciate it.

  0
• Account deleted

  hi @kefiiiiR! congrats on finishing the challenge!

  a couple suggestions:

  • Document should have one main landmark, this should contain the main part of your challenge, you can fix it like this:

  <div class="container">  <-- remove
  <main class="container">  --> add
  

  • All page content should be contained by landmarks, at the end of your code you have a div that can easily be a footer:

  <div class="attribution">  <-- remove
  <footer class="attribution">  --> add
  

  I hope this feedback has been useful to you! keep coding :)

  Marked as helpful

  0

  ---

  

  kefiiiiR•70

  @kefiiiiRPosted over 2 years ago

  @nachogonzalia Hi Nacho, very appreciate the suggestions. Done and done. Thank you for your feedback!

  1