Design comparison
SolutionDesign
Solution retrospective
Hi, I am learning Sass. I would like to have feedback on best practices and on design and code. This will help me learn sass and react.
Community feedback
- @besttlookkPosted over 2 years ago
Hi, Congts on completing this challeng. Following are the issue i like to point out.
- Tho it look okay for large screen and mobile but it is not entirely responsive. Add mode media-query or use flex-wrap or grid with auto-fit.
- Give padding in x direction. Content should never touch the boundry.
Other than than its good.
Good Luck #happyCoding
Marked as helpful0 - @Beats-AyushPosted over 2 years ago
Nice job completing this challenge. Some issues:
Background-color
of body is missing.- The text is the buttons is leaning towards the top. You can fix that by
display: flex; align-items: center;
.
0@kirtymeenaPosted over 2 years ago@Beats-Ayush Hi Thanks, I have fixed the button text but I am not able to fix the background color even though I have added background color in the card.scss file.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord