Column Preview Card Component Main / Grid and Flex

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 12 months ago

  Hi, good job on this challenge. Just a few things to take note of:

  HTML:

  • "Learn More" would navigate to another page, hence it should be a link, not a button.

  CSS:

  • On main, height:100vh should be min-height: 100vh.

  • It's good practice to include a CSS Reset at the top.

  • Font-size must never be in px. Use rem, or em like you have done elsewhere.

  Marked as helpful

  2

  ---

  

  P

  MarcoDV•280

  @MarcoDV47Posted 12 months ago

  @Islandstone89 Thanks for the feedback! I really appreciated you posting the articles and i learned a LOT from them. I can say i learned at least 3 very important things. I don't know yet if that's good or bad, but i create my CSS reset on a separate file. Thanks again :)

  1
• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted 12 months ago

  Hey,

  This looks great! Just a few small things you could perhaps do:

  • remove alt text from icons: as they are decorative, they can be left blank
  • you could add some left and right margin to the container - on certain screen sizes (770-920px) it's touching the sides of the screen

  The rest looks awesome, well done!

  Marked as helpful

  2

  ---

  

  P

  MarcoDV•280

  @MarcoDV47Posted 12 months ago

  @FluffyKas Thanks for the feedback! I applied the improvements. You pointed out things I overlooked and that will help me and my future projects, i appreciate it :)

  0