@AdrianoEscarabote
Posted
Hi Ali Mahmoud, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
Document should have one main landmark, this problem is being caused by the fact that there is no main tag around the main content of the page! Since this challenge is based on only one component, there is no other component more important than it on this page, so to solve this, wrap all the content with the main
tag,
It's always good to pay attention to the correct use of semantic html elements, as they are extremely important for people who use screen readers, to know what the main content of the page is in the case of the main
tag!
To improve the code structure wrap this div:
<div class="attribution">
with the semantic tag footer
The rest is great!
I hope it helps... 👍
Marked as helpful
@AliMahmoud21
Posted
@AdrianoEscarabote Thanks a lot, I will use the semantic elements in the coming challenges...