Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! Here are some suggestions to help improve your code:
-
Stay away from using libraries until you fully grasp the fundamentals. This is the purpose of this challenges.
-
Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.
-
Your “buttons” need to have a
:hoverand:focus-visible. -
Adjust the
paddingandfont-sizeof the component as the screen size decrease to better accommodate the smaller screen size.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
0 -
- @correlucasPosted about 2 years ago
👾Hello @iscanabdulhalik, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
1.Add the website favicon inserting the svg image inside the
<head>.<link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">2.Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a
single classto manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.3.Add the correct color for this background, the value is
background-color: #F2F2F2✌️ I hope this helps you and happy coding!
0@iscanabdulhalikPosted about 2 years ago@correlucas Thank's for your feedbacks! I will pay attention to what you says.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord