Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey @karliask, some suggestions to improve you code:
-
The headings are being use incorrectly. For this challenge, each heading is equally as important. So best option, is to use <h2> Heading, because it will give each card the same level of importance and it's reusable.
-
Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.
-
For the button border, you are suppose to use
border
not `outline. -
Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
Happy Coding! 👻🎃
0@karliaskPosted about 2 years ago@vcarames Thanks for the comment! about the buttons, i didnt really used anchors or anything because i only went for how the page looks and not how it should function, and i used outline because i was experimenting with it and forgot to change it back to border. Have a good day/night!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord