Column Card

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋 Hi Ezra Akankwasa! My name is Vanza!

  I have a feedback on mobile view. I think you can remove these two properties from your body style:

  body {
    margin-left: 17%;
    margin-right: 17%;
  }
  

  Since it makes all the cards right align (try to see it with dev tool and set the screen size to 360px * 640px).

  Also a feedback on your html, the best practice is always using only one h1 on header, so my recommendation is that change all h1 to h2.

  That's it! Hopefully this is helpful!

  Happy Coding!

  Marked as helpful

  0

  ---

  

  KingOfTheFlies•110

  @ezraakankwasaPosted about 3 years ago

  @vanzasetia Hey Vanza, yeah this was super helpful. I didn't understand media queries at all. And thanks for the h1 tip I've been using it a lot in my projects. All the best.

  0
• 

  P

  j5•2,290

  @jmnyaregaPosted over 3 years ago

  You did great @ezraakankwasa 🙌 and the semantic HTML is looking great.

  One Nitpick:

  • When hovering on the buttons, the whole card seems to shift position, you can easily fix that by giving the border the same value before and after hovering. your case, I think this should work.

  .btn {
       border: 0.15rem solid;  // on hover is 0.15rem too.
  }
  

  Marked as helpful

  0

  ---

  

  KingOfTheFlies•110

  @ezraakankwasaPosted about 3 years ago

  @jmnyarega I'll be sure to that. Also I've learnt a lot about the box model. At that point I didn't understand what I was doing, as long as the item moved I was happy😂. Thanks for the feedback

  0
• 

  Abdulaziz Ba Haj•70

  @AbdulazizBaHajPosted over 3 years ago

  Great work ezra!

  Marked as helpful

  0

  ---

  

  KingOfTheFlies•110

  @ezraakankwasaPosted about 3 years ago

  @AbdulazizBaHaj Thanks

  0