Design comparison
Community feedback
- @AdrianoEscarabotePosted about 1 month ago
Hello Alejandro Villa Herrera, how are you? I was really pleased with your project, but I’d like to offer some advice that might help:
Consider using
rem
for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.if you want to continue coding with
px
, you can download a very useful extension in vscode, it convertspx
torem
!link -> px to rem
Since this project is only based on a single page component, there is no need for a h1 tag. It's always a good idea to prevent accessibility errors, so I believe it would be beneficial for you to add a "h1" in this component. Don't worry if you forget about "h1," though; it's a good practice for when you are developing larger sites.
<h1>Coding bootcamp testimonials slider</h1>
The rest is spot on.
Hope it’s helpful to you. 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord