Code QR, RWD

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="box-qr"> with the main tag and <h3> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Give .box__qr-textbox a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text. Give p a font-color of hsl(220, 15%, 55%); for the faded color.

  Replace the min-height in .box-qr with a padding value for all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement. padding:16px which is 1rem.

  For a responsive content which wont require a media query for this challenge, replace the width in .box-qr with max-width and reduce its value for it to be equivalent to the design. max-width:320px which is 20rem/em

  Give the img a max-width of 100% for a responsive image and a border-radius value.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0
• 

  Kamilek•170

  @KamilbdPosted over 1 year ago

  So I understand that instead of the h3 tag I should use h1 and wrap it in sections with the role, right?

  0