Clock-app (Responsive, CSS-Grid, Flexbox, React, React-Query, Axios)

Community feedback

• 

  Fazza Razaq Amiarso•2,340

  @fazzaamiarsoPosted almost 2 years ago

  Hey David! Great Work!

  I have a quick tips. You can simplify your code in SlideIn component by removing useEffect and calculate the day and week outside the component as you want only to do it once. Here is my improvement.

  const MS_TO_HOUR = 60 * 60 * 1000;
  
  const getDayAndWeek = () => {
    const currDate = new Date();
    const startDate = new Date(currDate.getFullYear(), 0, 1);
    const days = Math.floor((currDate - startDate) / (24 * MS_TO_HOUR));
    const weekNum = Math.ceil(days / 7);
  
    return { dayNumber : days + 1, weekNumber: weekNum };
  }
  
  const SlideIn = ({ isSlideInActive, activeTimeLocalData }) => {
    const {dayNumber, weekNumber} = getDayAndWeek();
  
    return (
  // ...your other codes
  

  I hope it helps! Cheers!

  Marked as helpful

  0

  ---

  

  David•1,130

  @David-Henery4Posted almost 2 years ago

  @fazzaamiarso Hello Fazza, that's a great idea!

  I even abstracted the function into another file to make the component a bit more cleaner as well!

  That's for the tip mate, much appreciated Thank you!

  0