Design comparison
Solution retrospective
any feedback is welcome!!
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hello, superozzy! 👋
It's nice to see you complete another challenge (it's been a few weeks)! 😀 Well done on this one! 👍
I suggest,
- Placing the hero background image in the top-right corner of the page (rather than have it stretched out across the whole page).
- Making sure all of the logos in the logos section maintain their original aspect ratios so that they aren't distorted.
- Bringing the navigation links in the footer of the page closer together as in the original design (they seem quite spaced out in the desktop layout, at the moment).
- Taking a look at your solution report and trying to clear up the errors that are there (there seem to be a couple of duplicate ID's on the page).
Hope those tips help! 🙂
Keep coding (and happy coding, too)! 😁
1@superozzyPosted over 3 years ago@ApplePieGiraffe thanks for the advice,i think i' ve changed the most of the suggestions,but i have one question, how can i make the background-image to the top-right of the page,at this moment is only at the top!thanks again!!
0@ApplePieGiraffePosted over 3 years ago@superozzy
No problem! 😀
I think it would be better if you removed the background image from the
.head
(because that section covers the entire length of the page and makes the background image look very stretched) and added it to something like the.firstbox
section instead (you might have to increase the width and height for that section a bit, then, in order to make sure that it fills up the entire width of the page and extends to the top of the screen). 😉After doing so, you can add
background-position: top right
to make the background image move to the top-right of the page, or simply addbackground-size: cover
(since the area that the background image will be covering will be much smaller, then).Hope that works for you! 👍
Oh, and hey, if you found these comments helpful, an upvote would be appreciated! ;)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord