Design comparison
SolutionDesign
Community feedback
- @VbanetyPosted over 3 years ago
Thanks for all tips, I appreciate that and I'll try to fix these issues, the reason to put min-width, the width was less than 375px it starts to break the layout.
Thanks for the feedback.
0 - @grace-snowPosted over 3 years ago
Hi
Good job on this! Just a few pointers
- I'm getting odd horizontal scroll on mobile because of the min-width 375px. There's no reason to include that.
- you don't need to use the picture element unless you're serving multiple image sources (ie for different screen sizes)
- logo alt text needs to just say the name of the site/product. Really important, that one!
- generally all alt attributes on this need improving. If an image is meaningful, you need to write a legible Description in there. It can't be hyphenated phrases. It needs to communicate what the image shows even if you couldn't see it.
- Last thing - a suggestion really - semantically it would make much more sense for all those footer links to be in one unordered list, not spread across three. Look up css column properties, as that would give you the desktop footer layout you want without compromising the semantics.
Very good work overall. It looks close to the design, well done!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord