Design comparison
Solution retrospective
Any feedback or tips to make my HTML and CSS better would be appreciated very much :)
Community feedback
- @InterplanetaryDragonPosted over 4 years ago
Page looks great! That very minor HTML issue that has popped up is because you have a section without a heading. I checked the code and you used <section> several times. In most cases you'd be better off with a div, especially if there isn't a heading as it'll flag up.
It's just one of those things... you'd think it shouldn't really matter, which it shouldn't. I'd argue that logo area is a section, but a HTML checker will want it as a div. Semantics!
2@anthonyPasslerPosted over 4 years ago@InterplanetaryDragon Thanks so much for the tip - ill definitely update that.
0 - @InterplanetaryDragonPosted over 4 years ago
Also just noticed, your buttons don't seem to be buttons. Are they a tags with a background and border? Cool little solutions really. No difference visually speaking.
0@anthonyPasslerPosted over 4 years ago@InterplanetaryDragon yes I learnt in one of the tutorials to style tags as buttons - not sure if using a tag over a button is a better option though
0@InterplanetaryDragonPosted over 4 years ago@anthonyPassler Thanks for this. Never seen it before. Did some research and came across this article which was very informative: https://css-tricks.com/a-complete-guide-to-links-and-buttons/
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord