Design comparison
SolutionDesign
Solution retrospective
Feedbacks are appreciated.
Community feedback
- @grace-snowPosted almost 4 years ago
Hi Ritesh,
On mobile in the design, the heading line heights are tighter and the font sizes all consistent, which is different to what you seem to have here.
As well as that, I'd tweak the html elements you've chosen and make a few other small changes.
- most important is the logo needs alt text saying what the company/product is.
- It's also usual to have that logo inside a link (anchor tag), as that's an established pattern for a homepage link
- top heading should be a h1, then each heading go sequentially from there. I can see you've tried to do that, but it must start from h1 not h3
- all the content in your footer needs placing inside links
- I would also use lists for some of that footer content
- once links are added, remember to add focus and hover states.
Best of luck with it 👍
1@riteessshhPosted almost 4 years ago@grace-snow Thank you for your feedback. I'll keep these points in mind for future projects.
0@grace-snowPosted almost 4 years agoCool. If you want to use this as a portfolio piece make sure you fix the alt text, h1 and links. Those are the kinds of details that potential employers notice and puts them and puts them off interviewing
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord