Design comparison
Solution retrospective
How can i improve it ?
Community feedback
- @martam90Posted almost 4 years ago
Hi,
I have recently made the same challenge as you. Here are my suggestions:
Add cursor: pointer to buttons; Add hover state to icons in footer-social. Instead of putting img in index.html, paste there svg code for each icon; Add alt attributes to all images in index.html; Add some line-height to <p> tags;
Overall nice work, I hope you will find my hints helpful. :)
2@SeyBooPosted almost 4 years agoHey, thanks for your return !
I updated, but i can't figure it out how to change the color of the img
0@martam90Posted almost 4 years ago@SeyBoo Instead of img, paste svg you have in images folder. Each icon has own svg. When you paste the code to your index.html, erase from that code fill="#4C545C".
Add the fill and color you removed from index.html to your CSS. Then add hover state:
.footer-icon { fill: #4C545C; } .footer-icon:hover { fill: $cyan; }
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord