Design comparison
Solution retrospective
Feedback will be appreciated!! 😁 I have a problem with the color of the social media icons when its hovered. I can solve this by importing editable icons from somewhere else but i'll like to use the assets contained in the starter pack. I'd appreciate any help.
Community feedback
- @muhammadshajjarPosted about 3 years ago
Hi Nice Work, Awesome work on this one layout looks great and responds well on all sizes but there is a small issue that content is growing too much on larger viewports add
max-width
to a body or make a container class that wraps your all content, by adding it you can control your content from growing too much on larger viewports, it is first stepped to responsiveness in my opinion.I think you are on the right path of using the filter to your image on hover but the filter you used is not right Check out this code-pen it will generate filter which you want This is generated by this code pen,
.social a:hover { filter: invert(56%) sepia(100%) saturate(338%) hue-rotate(122deg) brightness(90%) contrast(85%); }
And if you would use direct SVG in your Html, This css tricks link would lead you to the best
Apart form this very well done, Keep up the great work
Marked as helpful0@Tomi-pterPosted about 3 years ago@muhammadshajjar Thanks a lot man. For the overgrowing problem, I added a [min-width: 1441px] query and set the (max-width) of the main to 80% and the footer height to 10vh. The css tricks article was really helpful too. Thanks 👍🏾
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord