Design comparison
Solution retrospective
I think the code can be improved, right? Comment your suggestions, please.
Community feedback
- @maciejkrol18Posted over 2 years ago
The code is overall pretty clean, point for using BEM in class names. However, please space out all of the stuff in your CSS file. It's very hard to read it as of now. I would also make all of the variable names lowercase - is there any reason color related variables are capitalized and all of the other ones are lowercase?
0@WaldoozkiPosted over 2 years ago@FancyBaguette Thanks for mentioning your points :)
I'm sure I'll do the spacing in the next practices. Regarding the color variables, they are capitalized because I copy the text in the style guide, so sometimes I tend to forget to rewrite the texts in lowercase.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord