@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
IMPROVE ARIA-LABELS FOR SOCIAL LINKS :
- The
<a>
needsaria-label
attribute with proper values instead of usingIcon of
orImage of
. You currently added like"Icon to Facebook"
. We need to provide details more clearer and crisper.
- Remember
aria-label
is important for social links in an<a>
tag can help provide more context to users with visual impairments who use assistive technologies such as screen readers to access your website.
- When a screen reader encounters an anchor tag with a social link, it may announce the link's text content, such as "Facebook" or "Twitter," by including an
aria-label
attribute that points to a nearby element containing a description of the link's purpose, you can provide more context and clarity to the user.
- So instead of saying
"Icon to Facebook"
you can say like"Visit us on Facebook"
- Example:
<a href="#" aria-label="Visit us on Facebook" class="footer__icon">
<svg>..Facebook svg...</svg>
</a>
- If you have any questions or need further clarification then feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful