Clipboard Landing Page with Grid and Flex

Community feedback

• 

  Shraddha•485

  @5hraddhaPosted almost 3 years ago

  Hey @tomashoj2001, I am very impressed to see how clean and structured your code is. It made me to go over it and understand it easily. Good job 👏

  There are a few suggestions from my side that you could look into for more improvements either for this challenge or the next one:

  1. Since, you have used BEM naming convention for CSS class names, you could also divide and modularize your css file into several smaller files and arrange them according to BEM File Structure Organization Methodologies. This would be beneficial for large projects especially. You could look into this link - https://en.bem.info/methodology/filestructure/

  2. Whenever you see that you have some repetition of elements in your HTML markup, there is always a chance to enhance the markup more semantically. In your case, when you have certain <p> elements with the same style repeated over amd over again, you could put these elements as list items of <ul> tag, to make it more semantically meaningful. Or if you want to take it to another level and play with JS a bit, you could put the repeating block of code in a <template> tag and then, in JS clone the template and create all the repeated elements dynamically. <template> tag is interesting one.

  Good luck!!

  Marked as helpful

  0
• 

  Tomi Hojnadel•430

  @tomashoj2001Posted almost 3 years ago

  Ohh thank you so much @5hraddha! I appreciate it a lot!

  1