Design comparison
Solution retrospective
Any feedback is appreciated. I try to implement this landing page as much as responsive :)
Community feedback
- @FluffyKasPosted almost 3 years ago
Hiyo,
Well done, it looks pretty good! Responsiveness is also fine, except a few smaller issues.
-
Your font-size is very small below 770px, almost unreadable. You should definitely increase that.
-
Heading levels are a bit all over the place. There's an important reason to have some sort of structure when using them. You could learn more from this video.
-
In the footer, your social media icons should be wrapped in links (since it's their function to point at social media websites). Don't forget to include aria-labels ^^
-
Alt texts: read this article, then perhaps you could make some adjustments :)
Other than these, you did very good so well done! Happy coding ^^
1 -
- @GitHub-dev12345Posted almost 3 years ago
Congratulation to complete your challenge: my small Suggestion for your project: you give the <br> ( Break tag ) in para line, check the project design paragraph, and then give the <br> tag according the deisgn:
I hope you find this helpful👍
0@FluffyKasPosted almost 3 years ago@zorluozan Don't do that :D @GitHub-dev12345, please read what br element is for.
0@GitHub-dev12345Posted almost 3 years ago@FluffyKas br element for break the line properly , and i personal used br tag in my project got it 😎
0@zorluozanPosted almost 3 years ago@FluffyKas I didn't do that :D . I think there may be some css tricks to do that thing but I don't know.
0@FluffyKasPosted almost 3 years ago@zorluozan Yes, if you wanted your text to follow the design and break at certain point, you can add a
max-width
on it (andmargin: auto
to center it) to control its width ^^0@FluffyKasPosted almost 3 years ago@GitHub-dev12345 As I said above, please read MDN. It specifies exactly when it should be used and when isn't. ^^
br
element has a semantic meaning. If you'd like to style any text, you should do so by using css!0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord