Clipboard Landing page using Grid/Flex

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 3 years ago

  There are errors that have been identified in the report. Are they major errors? I would say , some of them must be fixed

  • <button class="ios-button"><a href="#">Download for iOS</a></button>. A button and an anchor element are both interactive elements. They should not be nested at all.
  • while using more than one h1 element on a page does not cause errors ,it is considered not best practice as it is not beneficial to assistive tech users.
  • alt values should be descriptive to assist , assistive tech users to visualize the message that is being put across. Decorative images should have an empty alt value. <img src="./images/icon-blacklist.svg" alt="blacklist icon" /> - this alt value in my opinion is shallow. Maybe it should be a decorative image.
  • as for the display , you did a good job. Looks good on most devices

  Happy coding

  1

  ---

  

  Matthew Pierce•495

  @shake88juntPosted about 3 years ago

  @ChamuMutezva Thanks, the button issue is definitely a problem, I may fix it. What should I use instead of h1 tags then? Ty a lot man.

  0

  

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 3 years ago

  @shake88junt, heading elements must ascend in order with respect to the structure of your html. H1, h2, h3 etc. For the other heading elements it is not any issue if for example there is more than one h2 elements. A scenario like when your content has section A, section B, section B - the first headings in the sections can be an h2 and follow the sequencial order from there on

  1
• Account deleted

  It looks ok, and you should take a look at the report and fix some of the issues mentioned.

  1