Design comparison
Solution retrospective
Feel free to live your feedback.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
ANCHOR ELEMENT π΄:
- The social links
img
elements need to be wrapped witha
element andaria-label
attribute which is way more important for social links in an<a>
tag can help provide more context to users with visual impairments who use assistive technologies such as screen readers to access your website.
- When a screen reader encounters an anchor tag with a social link, it may announce the link's text content, such as "Facebook" or "Twitter," by including an
aria-label
attribute that points to a nearby element containing a description of the link's purpose, you can provide more context and clarity to the user.
- By providing this additional information, you can help users with visual impairments to better understand the purpose and value of social links, and encourage them to engage with your content. This can ultimately improve the user experience on your website, and make it more accessible and inclusive for all users.
- Example:
<a href="#" aria-label="Facebook profile of Clipboard"> <img class="svg" src="assets/icons/icon-facebook.svg" alt=""> </a>
- If you have any questions or need further clarification and/or feel free to reach out to me.
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1 - @NehalSahu8055Posted over 1 year ago
Hello Coder π.
Congratulations on successfully completing the challenge! π
Few suggestions regarding design.
-
Add
background-size:100%
to your body to make you bg responsive to all devices. -
Don't use
<button>
and<a>
at the same time use<a>
instead it is linking to somewhere. Just shift the attribute class to<a>
from<button>
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google. link.
I hope you find this helpful.
Happy codingπ
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord