Design comparison
Solution retrospective
Your feedbacks are welcome :D
Peace ☮🕊✌
Community feedback
- @FluffyKasPosted over 2 years ago
Heyo,
This looks really great! ^_^ Your code is neat and easy to read. Only have a few notes to make:
-
The company logo in the footer area is really small on some screen widths (between 660 and 880px or so). Perhaps you could align it a bit differently or adjust the footer's media query?
-
Your social media links in the footer could be wrapped in <a> tags and given aria-labels.
-
Font-sizes are best set in relative units instead of pixels.
-
There's a fixed height of 100vh on the
body
which might cause some issues on phones or smaller screens. You can actually just remove the height entirely.
Marked as helpful1@JayDeeZzzPosted over 2 years agoHi @FluffyKas,
Thank you so much for your valuable time & the comments. I'll fix those issues asap :D
Cheerers :)
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord