Clipboard Landing Page - SCSS, Flexbox, Grid

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hello, Anna! 👋

  Great to see another just about pixel-perfect solution from you! 🙌

  I like the subtle but beautiful transitions for the buttons and navigation links and your solution responds very well. 👍

  Looking at your code, I think you've made great use of BEM in your HTML and I like the organization of your Sass files (it's just how I like to organize my Sass files, too). 👏

  Just a small tip—I think you can use the universal selector to select all of the elements inside of an SVG element to change its color upon hover (so that you don't have to manually add a class to each element inside it), like so,

  svg:hover * {
      fill: #hsl(blah, blah, blah);
  }
  

  There's getting less and less to say about how you can improve with each project. 😉 Keep it up! 😊

  Of course, keep coding (and happy coding, too)! 😁

  2

  ---

  

  BerylBucket•280

  @BerylBucketPosted about 4 years ago

  @ApplePieGiraffe This is probably just a typo, but it should be

  svg:hover * {
      fill: hsl(blah, blah, blah);
  }
  
  

  2

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  @BerylBucket

  Correct! Missed that, thanks! 👍

  0

  

  Anna Leigh•5,135

  @brasspetalsPosted about 4 years ago

  @ApplePieGiraffe @BerylBucket Thank you both for alerting me about the simplified hover fix! I got into an unconscious habit of using a class after a solution where I had to selectively pick areas of an svg to change. Anyway, all fixed now! 👍

  APG - Glad to hear my BEM has improved! The article you linked on my Ping solution is responsible for the button transitions, and your solution was actually the inspo for my footer link responsiveness, so thanks again!

  1