Clipboard landing page, Responsive by using sass

Community feedback

• 

  nganbarova•190

  @nganbarovaPosted about 4 years ago

  It is looking great.I am not an expert so I can not tell anything about technical part of code.But its responsiveness is working great.Keep up good work! Why haven't you put attribution part?

  1

  ---

  

  Abdulla Bashiroglu•520

  @bashirogluPosted about 4 years ago

  @nganbarova Thank you for your words. Though you are not an expert, I am sure you can contribute somehow. I didn't get the attribution part, so if you can clarify your question, I can answer. BTW, most probably you don't get notifications when people comment on your solutions. It would be great to check out your solutions from time to time.

  0

  

  Abdulla Bashiroglu•520

  @bashirogluPosted about 4 years ago

  @nganbarova So it would be great to check out your solutions from time to time.

  0

  

  nganbarova•190

  @nganbarovaPosted about 4 years ago

  @bashiroglu Attibution is the part that says that this is a challenge by Front End Mentor and It also contains your name so that others know that you are the one who coded the webpage.By default attribution should be in footer part,but I always put it in header part so people will immediately see my name.

  0

  

  Abdulla Bashiroglu•520

  @bashirogluPosted about 4 years ago

  @nganbarova I see what you mean, but that part ruin general design for me) so I get rid of it. But always keep the readme file in my repository so everyone knows that is done by me and designed by frontendmentors to give credit.

  0
• 

  Roman Filenko•3,335

  @rfilenkoPosted over 4 years ago

  Hey, solid work on responsiveness and structuring your code. Try to be consistent with spacing (different values of margins and padding), and not to repeat css styles. Next challenge to use some css preprocessor. 😉

  Cheers, Roman

  1
• 

  Abdulla Bashiroglu•520

  @bashirogluPosted over 4 years ago

  Thank you Roman, Yes I have some problems with consistent padding or margins. I am working on it. But in this project, I used preprocessor(SASS).

  0

  ---

  

  Roman Filenko•3,335

  @rfilenkoPosted over 4 years ago

  @bashiroglu Hi, nice, didn't noticed, maybe this article will be useful for you - https://medium.com/codyhouse/create-your-design-system-part-4-spacing-895c9213e2b9.

  1

  

  Abdulla Bashiroglu•520

  @bashirogluPosted about 4 years ago

  @rfilenko Thank you, 2 months later, I saw your comment and I will look at the article tomorrow.

  0