Design comparison
SolutionDesign
Solution retrospective
Any advice to improve will be welcome! :)
Community feedback
- @rfilenkoPosted over 4 years ago
Hey, nice job overall, a few notes to improve:
- class namings could be better, sometimes repeating css styles;
- be consistent with values (like margin: 150px 0 4em; padding: 1em 0 3.5em;), follow vertical rhytm(choose one, for example, margin-bottom for spacing between elements);
- add transition to links, buttons;
- check into css variables.
Keep practicing, Roman
1@iamdulcePosted over 4 years agoThank you so much, Roman! I'll follow your suggestions and improve the project! :D
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord