Clipboard landing page master. With Flex, BEM. HTML5, CSS3

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Art! 👋

  Congrats on finishing another challenge! Your solution looks very good and also responds well. Here's my few tips:

  • Your background-image doesn't stretch more than 1440px screen size so it looks bad at higher resolutions. Add background-size: cover; to .intro element to solve that problem.
  • Change the alt attributes for the .intro__logo, .col1__logo , as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.
  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Art•420

  @Art-wdtPosted over 3 years ago

  Hi @tediko ! Thanks for the advice! Very detailed! Very informative! I will study and apply this in the future! Thanks for the knowledge

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  Looks good so far

  It looks like you are missing the Hover state on the buttons and the social icons

  1

  ---

  

  Art•420

  @Art-wdtPosted over 3 years ago

  Hi @palgramming Thanks for the advice! I forgot about it

  0