Design comparison
SolutionDesign
Solution retrospective
TailwindCSS
Community feedback
- @JaneMorozPosted almost 2 years ago
Hey! Your solution to this challenge is awesome! ❤️
The only things I've noticed:
- You need to wrap the main content of the page into the <main> tag. It will solve all these landmark issues.
- If you use button/link without any text (or just image/icon), I suggest to add aria-label to the <button>/<a> tag to improve accessibility. You can read more about it here. For example:
<a href="#" aria-label="facebook"><img src="../images/icon-facebook.svg" alt="" class="duration-200 ficon"></a>
- Also you might want to add
cursor: pointer
to the links.
Keep it up! And good luck 🍀
Marked as helpful1@davdifrPosted almost 2 years ago@JaneMoroz Hey, thanks for the suggestions!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord