Design comparison
SolutionDesign
Solution retrospective
Tried my best, hoping to get some feedback
Community feedback
- @vanzasetiaPosted over 2 years ago
Hello there! 👋
Good effort on this challenge! 👍
Some suggestions from me.
- Put the
footer
outside of themain
landmark.footer
element would only have role or mentioned by the screen reader if it lives outside themain
element. - The logo is an important image so add alternative text to it. It's one of the way for search engine bots and screen reader users to know what the site is called.
- The social media icons should be wrapped by link elements. They are actually the links of company's social media accounts.
I hope this helps!
Marked as helpful0 - Put the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord